Repository navigation
Fix AgentX profiling on SGLang without shape discovery - #117
Merged
Merged
Conversation
Collaborator
|
https://github.com/AMD-AGI/TraceLens/tree/main/TraceLens/TraceUtils/kernel_shape_tool -> this is the Patchless tool that we use instead of shape_discovery. we need to run to see if this has to be exported into the PYTHONPATH at Magpie/Hyperloom |
Member
Author
|
@mohbasit Since this is a feature that can be implemented in parallel, we can create another PR to add support for this tool |
mohbasit
previously requested changes
Oct 8, 2026
Collaborator
|
Please limit this PR to make shape_discovery optional and not addition of a new flag SGLANG_ENABLE_CUDA_GRAPH_CAPTURE_TRACE |
devalshahamd
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magpie now accepts SGLang detailed profiling when the runtime supports annotations but lacks shape discovery, addressing the capability check reported in #116.
shape_discoveryand enable graph shape discovery only when the runtime supports them.The existing
SGLANG_GRAPH_BATCH_CAPTUREbehavior is preserved. Patchlesskernel_shape_toolintegration is a separate follow-up.Validation at
d16f8013e:Boundary: GPU capture using the retained per-batch export path still needs validation for this revision. Full TraceLens/Roofline analysis and the Hyperloom optimization loop have not been validated. Annotation support alone does not establish trace quality for Roofline analysis.
Hyperloom must update its Magpie commit pin and audited package fingerprint to consume this fix.
Fixes #116.